Fix UI lobby profile editor#1056
Draft
Lachklen wants to merge 9 commits intoWWhiteDreamProject:masterfrom
Draft
Conversation
Contributor
Author
|
Всё я пошёл |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughРеализована функция управления неиспользуемыми загрузками (loadouts) в редакторе профиля персонажей. Добавлены UI элементы для отображения и удаления неподходящих загрузок, расширена логика обновления состояния загрузок с проверкой требований, и реализовано распространение видимости загрузок через иерархию компонентов. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Fix all issues with AI agents
In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml`:
- Around line 199-214: The LoadoutsRemoveUnusableButton currently has an English
placeholder ("You shouldn't see this"); change its initial Text to a neutral
value (e.g., empty string or a localized placeholder) in the XAML so the user
never sees the English message, and ensure the UpdateLoadoutsRemoveButton method
is responsible for populating the final label at runtime for
LoadoutsRemoveUnusableButton.
In `@Content.Client/Lobby/UI/HumanoidProfileEditor.xaml.cs`:
- Around line 2406-2441: CheckAndHideTabs only hides tabs but never restores
them; change the logic so it sets visibility explicitly based on current content
(i.e., call container.SetTabVisible(tabId, !shouldHide) instead of only hiding),
ensure CheckNestedContainer still recurses into nested NeoTabContainer and
returns whether it has any visible child controls, and update HasVisibleTraits
to reflect current selector.Visible state; also wire a call to
CheckAndHideTabs(TraitsTabs) (or the same updater) whenever filters/state that
affect trait visibility (e.g., "show unusable") change so tabs are re-evaluated
and shown again when traits become visible.
- Around line 2482-2503: The UpdateLoadoutsRemoveButton method sets the wrong
style class on LoadoutsRemoveUnusableButton causing OpenRight to be applied
instead of OpenLeft; update both branches in UpdateLoadoutsRemoveButton to
RemoveStyleClass(StyleBase.ButtonOpenLeft) /
AddStyleClass(StyleBase.ButtonOpenLeft) as appropriate (replace references to
StyleBase.ButtonOpenRight with StyleBase.ButtonOpenLeft) so the button matches
the XAML and avoids duplicate/conflicting rounded-corner classes.
- Around line 2457-2479: После удаления лодаутов в TryRemoveUnusableLoadouts
Profile обновляется, но не вызываются методы, которые обновляют превью и флаг
"dirty"; исправьте это, либо вызвав существующую общую логику (вызвать
OnLoadoutsChange() после присвоения Profile), либо явно вызвать
ReloadProfilePreview() и ReloadClothes() и обновление состояния сохранения после
строки Profile = currentProfile; чтобы превью и кнопки сохранения
синхронизировались с новым Profile.
Contributor
Author
|
Там если что в процессе всё |
Contributor
Author
|
Сделаю-ка я драфт |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание PR
Небольшой фикс разного рода UI в редакторе персонажа:
Медиа
Список
Лоадауты:
Трейты:
Изменения
🆑 Myaflic